Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for interface type in schema check #2924

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Sep 23, 2019

PR [ 1 / 3] breaking down #2917.
Related to #2775.

Description

Adds support for interface{} type signature to schema changes checker. It would panic otherwise on v1beta5 for example.

User facing changes

n/a

Next PRs.

  • (6 files) the new comment management logic and hooking it up to release and new_config
  • (20 files) update of the comments historically on all config.go files

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #2924 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/server/server.go 58.57% <0%> (ø) ⬆️

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Sep 23, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 23, 2019
@tejal29 tejal29 merged commit 4af79d5 into GoogleContainerTools:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants