Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HaTS and Opt-In Feedback links #2919

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Sep 20, 2019

Relates to in case of new feature, this should point to issue/(s) which describes the feature

Description

This PR add the Skaffold Survey links to our documentations

User facing changes

Skaffold docs Changes listed above.

Before

After

Next PRs.
n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [ n/a] Includes unit tests
  • [ X] Mentions any output changes.
  • [ X] Adds documentation as needed: user docs, YAML reference, CLI reference.
  • [ n/a] Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

@tejal29 tejal29 added docs-modifications runs the docs preview service on the given PR and removed meta/docs-preview labels Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #2919 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/build/local/bazel.go 35.71% <0%> (-36.22%) ⬇️
pkg/skaffold/docker/image.go 72.81% <0%> (-2.31%) ⬇️
pkg/skaffold/build/cluster/kaniko.go 53.24% <0%> (-1.19%) ⬇️
pkg/skaffold/schema/defaults/defaults.go 91.08% <0%> (-0.98%) ⬇️
pkg/skaffold/update/update.go 34.61% <0%> (-0.87%) ⬇️
pkg/skaffold/kubernetes/log.go 38.26% <0%> (-0.68%) ⬇️
pkg/skaffold/event/event.go 92.21% <0%> (-0.49%) ⬇️
pkg/skaffold/build/cache/hash.go 71.87% <0%> (-0.44%) ⬇️
pkg/skaffold/schema/profiles.go 88.43% <0%> (-0.14%) ⬇️
cmd/skaffold/app/cmd/config.go 100% <0%> (ø) ⬆️
... and 79 more

@container-tools-bot
Copy link

Please visit http://34.94.71.232:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 20, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Just a couple small comments.

docs/config.toml Show resolved Hide resolved
docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great to see, I'm excited about this going in!
Added comments, also I would put the feedback page under Resources, like http://34.94.71.232:1313/docs/resources/#release-notes - http://34.94.71.232:1313/docs/resources/#feedback - it is not a Reference material.

docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/references/feedback/_index.md Outdated Show resolved Hide resolved
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Sep 23, 2019
@container-tools-bot
Copy link

Please visit http://35.236.1.119:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Sep 23, 2019
@balopat balopat merged commit e01b9a8 into GoogleContainerTools:master Oct 16, 2019
@tejal29 tejal29 deleted the add_hats_survey_links branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants