-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HaTS and Opt-In Feedback links #2919
Add HaTS and Opt-In Feedback links #2919
Conversation
Codecov Report
|
Please visit http://34.94.71.232:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Just a couple small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great to see, I'm excited about this going in!
Added comments, also I would put the feedback page under Resources, like http://34.94.71.232:1313/docs/resources/#release-notes - http://34.94.71.232:1313/docs/resources/#feedback - it is not a Reference material.
Please visit http://35.236.1.119:1313 to view changes to the docs. |
60d560a
to
32eb333
Compare
32eb333
to
c34c854
Compare
Relates to in case of new feature, this should point to issue/(s) which describes the feature
Description
This PR add the Skaffold Survey links to our documentations
User facing changes
Skaffold docs Changes listed above.
Before
Readme on master
docs on master
After
Readme on my branch
docs on PR
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examples
dir, please copy them tointegration/examples
integration/examples
dir, should be tested in integration testReviewer Notes