-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setFiles
to HelmDeploy.HelmRelease
skaffold config which will be add --set-files
argument to helm CLI
#2895
Conversation
@marti1125 please run |
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seen a minor nit but otherwise okay
setFiles
to HelmDeploy.HelmRelease
skaffold config which will be add --set-files
argument to helm CLI
Relates to #2678
Fixes #2678
Description
Add
setFiles
config to helm deployer and plumb it through to add it helm CLI.User facing changes
Write n/a if not output or log lines changed and no behavior is changed
n/a
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examples
dir, please copy them tointegration/examples
integration/examples
dir, should be tested in integration testReviewer Notes
Release Notes