Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setFiles to HelmDeploy.HelmRelease skaffold config which will be add --set-files argument to helm CLI #2895

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

marti1125
Copy link
Contributor

@marti1125 marti1125 commented Sep 17, 2019

Relates to #2678

Fixes #2678

Description

Add setFiles config to helm deployer and plumb it through to add it helm CLI.

User facing changes
Write n/a if not output or log lines changed and no behavior is changed
n/a

Next PRs.
n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

 Add `setFiles` to `HelmDeploy.HelmRelease` skaffold config which will be add `--set-files` argument to helm CLI

@tejal29
Copy link
Contributor

tejal29 commented Sep 19, 2019

@marti1125 please run make generate-schemas and add tests by refactoring your lines into another small function and passing latest.HelmRelease with empty, non-empty values.

@tejal29 tejal29 self-assigned this Sep 19, 2019
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Sep 19, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #2895 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/deploy/helm.go 74.9% <100%> (+0.69%) ⬆️
pkg/skaffold/deploy/resource/deployment.go 94.28% <0%> (-5.72%) ⬇️
pkg/skaffold/deploy/status_check.go 56.48% <0%> (-2.65%) ⬇️
pkg/skaffold/build/custom/custom.go 63.93% <0%> (-1.86%) ⬇️
pkg/skaffold/initializer/init.go 57.45% <0%> (-1.69%) ⬇️
pkg/skaffold/build/cluster/sources/sources.go 90.9% <0%> (-0.68%) ⬇️
pkg/skaffold/jib/jib.go 73.48% <0%> (ø) ⬆️
pkg/skaffold/schema/defaults/defaults.go 91.02% <0%> (ø) ⬆️
pkg/skaffold/deploy/resource/base.go 84.61% <0%> (ø)

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seen a minor nit but otherwise okay

@tejal29 tejal29 changed the title Add support for #2678 Add setFiles to HelmDeploy.HelmRelease skaffold config which will be add --set-files argument to helm CLI Sep 23, 2019
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Sep 24, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 24, 2019
@tejal29 tejal29 merged commit 885827d into GoogleContainerTools:master Sep 24, 2019
@tejal29 tejal29 mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for --set-file in helm deployer
6 participants