Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold trace -> kaniko debug #2823

Merged
merged 1 commit into from
Sep 6, 2019
+5 −1
Merged

skaffold trace -> kaniko debug #2823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
skaffold trace -> kaniko debug
@balopat
balopat committed Sep 6, 2019

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
commit 12a1b61702cf43e46241237fdb6d3730609fd0e5
5 changes: 4 additions & 1 deletion pkg/skaffold/build/cluster/logs.go
View file
Original file line number Diff line number Diff line change
@@ -28,12 +28,15 @@ import (
corev1 "k8s.io/client-go/kubernetes/typed/core/v1"
)

// logLevel makes sure kaniko logs at least at Info level.
// logLevel makes sure kaniko logs at least at Info level and at most Debug level (trace doesn't work with Kaniko)
func logLevel() logrus.Level {
level := logrus.GetLevel()
if level < logrus.InfoLevel {
return logrus.InfoLevel
}
if level > logrus.DebugLevel {
return logrus.DebugLevel
}
return level
}

1 change: 1 addition & 0 deletions pkg/skaffold/build/cluster/logs_test.go
View file
Original file line number Diff line number Diff line change
@@ -28,6 +28,7 @@ func TestLogLevel(t *testing.T) {
logrusLevel logrus.Level
expected logrus.Level
}{
{logrusLevel: logrus.TraceLevel, expected: logrus.DebugLevel},
{logrusLevel: logrus.DebugLevel, expected: logrus.DebugLevel},
{logrusLevel: logrus.InfoLevel, expected: logrus.InfoLevel},
{logrusLevel: logrus.WarnLevel, expected: logrus.InfoLevel},