Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small random fixes to tests and code #2801

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Small random fixes to tests and code #2801

merged 1 commit into from
Sep 4, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Sep 4, 2019

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #2801 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/kubectl/cli.go 100% <ø> (ø) ⬆️
pkg/skaffold/docker/reference.go 100% <100%> (ø) ⬆️
pkg/skaffold/docker/client.go 73.73% <100%> (+0.54%) ⬆️

@dgageot dgageot merged commit b4ba29a into GoogleContainerTools:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot