Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flake in in-cluster build #2799

Merged
merged 5 commits into from
Sep 6, 2019
Merged

fix flake in in-cluster build #2799

merged 5 commits into from
Sep 6, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Sep 4, 2019 •
edited
Loading

Fixes #2781.

@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #2799 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/runner/dev.go 66.66% <0%> (-1.48%) ⬇️

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 4, 2019
@balopat balopat marked this pull request as ready for review September 6, 2019 01:10
@dgageot dgageot merged commit 47de12f into GoogleContainerTools:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestBuildInCluster is flaky
4 participants
@balopat @dgageot @googlebot @kokoro-team