Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve skaffold init behaviour when tags are used in manifests #2773

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Improve skaffold init behaviour when tags are used in manifests #2773

merged 1 commit into from
Sep 5, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 30, 2019

  • Skaffold init now ignores images that can't be parsed
  • It also ignores images references by digest in the manifests
  • Skaffold run/dev ignore tags (not digests) in manifests

Fixes #834 and #2463

@codecov
Copy link

codecov bot commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #2773 into master will decrease coverage by 0.07%.
The diff coverage is 56.52%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 59.14% <0%> (-2.15%) ⬇️
pkg/skaffold/deploy/kubectl/images.go 92.18% <100%> (-0.24%) ⬇️

@dgageot dgageot force-pushed the improve-init branch 3 times, most recently from 306399a to 1b0fab0 Compare September 2, 2019 07:34
@dgageot dgageot mentioned this pull request Sep 3, 2019
Closed
nkubala
nkubala reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to see this documented somewhere, but i'm not really sure the right place. this behavior is a little nuanced so maybe somewhere in the tagging section of the docs we can have a little write-up explaining how this works?

also, I think this PR fixes #2512 right?

pkg/skaffold/deploy/kubectl/images.go Outdated Show resolved Hide resolved
pkg/skaffold/initializer/init.go Outdated Show resolved Hide resolved
pkg/skaffold/initializer/init.go Outdated Show resolved Hide resolved
@dgageot dgageot force-pushed the improve-init branch 3 times, most recently from d2c347c to ea67f2f Compare September 4, 2019 12:36
@dgageot
Copy link
Contributor Author

dgageot commented Sep 4, 2019

@nkubala This should be good to go

@dgageot
Ignore tags (not digests) in manifests
e3fd350 
 + skaffold init ignores tags
 + deployers ignores tags

Fixes GoogleContainerTools#834
Fixes GoogleContainerTools#2463
@nkubala nkubala merged commit 93df0d2 into GoogleContainerTools:master Sep 5, 2019
@gsquared94 gsquared94 mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore tag in skaffold.yaml and kubernetes yaml
3 participants
@dgageot @nkubala @googlebot