Add logs when listing files to be watched #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
nkubala
reviewed
Aug 28, 2019
pkg/skaffold/runner/dev.go
Outdated
| return errors.Wrapf(err, "watching files for artifact %s", artifact.ImageName) | ||
| } | ||
|
|
||
| fmt.Fprintf(out, "%d\n", count) |
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(out, "%d\n", count) | |
| color.Default.Fprintf(out, "%d files being watched for artifact\n", count) |
There was a problem hiding this comment.
I find that too verbose but yes, my version is not good either. I removed that second commit. Should be good to review
Fixes GoogleContainerTools#2742 Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
fix-2742
branch
2 times, most recently
from
910eea0 to
369b224
Compare
nkubala
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2742
Next step will be to compute those files in separate go routines and maybe print the number of files for each artifact
Signed-off-by: David Gageot [email protected]