Add struct for generate_pipeline to keep track of related data #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlon-gamez
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tejal29
requested changes
Aug 20, 2019
tejal29
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ConfigFile struct ties a file to its corresponding SkaffoldConfig and the Profile that gets generated from that config. This PR adds the struct and refactors generate_pipeline code to utilize it.
This prepares for the generate-pipeline command to support multiple skaffold config files.