Implement exponential backoff for retrieving cloud build status #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
balopat
reviewed
Aug 16, 2019
balopat
reviewed
Aug 16, 2019
balopat
previously requested changes
Aug 16, 2019
balopat
approved these changes
Aug 22, 2019
|
Looks like the error message has changed and therefore the exponential backoff no longer works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when several GCB builds were happening simultaneously (particularly long running builds), the rate limit would get hit for retrieving the build status, causing the build to fail. This implements an exponential backoff for retrieving this build status, so these jobs can keep running.
Fixes #1589