Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed broken link, since the page doesn't exists anymore #2644

Merged

Conversation

Zyqsempai
Copy link
Contributor

Fixes #2634
Removed broken link, since the page doesn't exists anymore

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #2644 into master will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/config/util.go 54.28% <0%> (-5.07%) ⬇️
pkg/skaffold/deploy/kustomize.go 72.32% <0%> (-1.76%) ⬇️
...g/skaffold/kubernetes/portforward/pod_forwarder.go 85.48% <0%> (-1.48%) ⬇️
pkg/skaffold/deploy/kubectl.go 65.51% <0%> (-1.45%) ⬇️
pkg/skaffold/event/event.go 88.59% <0%> (-1.21%) ⬇️
pkg/skaffold/deploy/helm.go 66.54% <0%> (-1%) ⬇️
cmd/skaffold/app/cmd/runner.go 69.23% <0%> (ø) ⬆️
pkg/skaffold/pipeline/task.go 100% <0%> (ø) ⬆️
...ffold/kubernetes/portforward/port_forward_entry.go 100% <0%> (ø) ⬆️
pkg/skaffold/deploy/labeller.go 100% <0%> (ø) ⬆️
... and 17 more

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit but otherwise LGTM. thanks for doing this!

* any Kubernetes platform with Skaffold; see [Picking the Right Solution](https://kubernetes.io/docs/setup/pick-right-solution/)
from Kubernetes documentation for instructions on choosing the
right platform.
* any Kubernetes platform with Skaffold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* any Kubernetes platform with Skaffold
* any Kubernetes platform with Skaffold.

@Zyqsempai
Copy link
Contributor Author

@nkubala Done.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Aug 15, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 15, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you!

@nkubala nkubala merged commit 9600d0d into GoogleContainerTools:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started - broken link
6 participants