Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link task resources in generate-pipeline output #2638

Merged
merged 3 commits into from
Aug 14, 2019

Conversation

marlon-gamez
Copy link
Contributor

Adds connection of resources from build to deploy task. Removes the need for runAfter. Instead, the task order is determined resource dependency. This allows the deploy task to use the build.out file that is generated by the build task.

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #2638 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/pipeline/task.go 100% <100%> (ø) ⬆️
...kg/skaffold/generate_pipeline/generate_pipeline.go 54.34% <100%> (+1.36%) ⬆️

@marlon-gamez
Copy link
Contributor Author

marlon-gamez commented Aug 12, 2019

closed & reopened to get travis to rerun a flaky test

@tejal29 tejal29 merged commit 686e75f into GoogleContainerTools:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants