Pass minikube docker configuration to container-structure-test

[corneliusweig]

Fixes #1296

[codecov]

Codecov Report

Merging #2597 into master will increase coverage by 0.02%.
The diff coverage is 86.66%.

Impacted Files	Coverage Δ
pkg/skaffold/test/structure/structure.go	100% <100%> (ø)	⬆️
pkg/skaffold/test/structure/types.go	100% <100%> (ø)	⬆️
pkg/skaffold/test/test.go	94.28% <60%> (-5.72%)	⬇️

[tejal29]

Thanks @corneliusweig. Have you verified if this works on when kubectl context is minikube?

[tejal29]

@corneliusweig can we add a unit test to make sure the env structure.NewRunner is actually plumbed through?

func (c *FakeCmd) WithRunEnv(command string, env map[string]string) *FakeCmd {
  return c.addRun(run{
		command: command,
		env: env,
	})
}

and then RunCmd should check if the

func (c *FakeCmd) RunCmd(cmd *exec.Cmd) error {
 ....
  if r.env != nil{
	if cmd.Env == r.cmd {
              // Error if both maps are not equal.
	}
 }
}

[tejal29]

Add tests.

[corneliusweig]

Hey @tejal29, sorry for my slow response, I was travelling. I did check that container-structure-test works correctly with minikube now. I also added a test to assert on correct plumbing of the env variables. So PTAL.

[corneliusweig]

Another victim of #2606. Let's hope for the next CI run :)

[tejal29]

LGTM!