Faster tests #2570
Merged
Faster tests #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgageot
commented
Jul 30, 2019
•
dgageot
commented
- Optimize all tests that take over .6s
- Use t.Override in placed where it should be used
- Remove TestRemoteDigest that was not really testing anything
- Run git tests in parallel
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
|
This PR decreases a bit the code coverage but it was code that was executed only by error. |
+ Optimize all tests that take over .6s + Use t.Override in placed where it should be used + Remove TestRemoteDigest that was not really testing anything + Run git tests in parallel Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
tejal29
approved these changes
Jul 31, 2019
| @@ -81,6 +83,9 @@ func TestCreateNewRunner(t *testing.T) { | |||
| } | |||
| for _, test := range tests { | |||
| testutil.Run(t, test.description, func(t *testutil.T) { | |||
| t.Override(&update.GetLatestAndCurrentVersion, func() (semver.Version, semver.Version, error) { | |||
There was a problem hiding this comment.
nice! didn't know all tests were doing the update check.
|
|
||
| defaultPollPeriodInMilliseconds = 100 | ||
| defer func() { defaultPollPeriodInMilliseconds = originalPollingPeriod }() | ||
| t.Override(&executeRolloutStatus, test.mock.Executefunc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.