Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Sync code #2564

Merged
merged 5 commits into from
Jul 29, 2019
Merged

Simplify Sync code #2564

merged 5 commits into from
Jul 29, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 29, 2019

Also rename the runContext package for simpler imports

Signed-off-by: David Gageot <[email protected]>
This simplifies the import statements

Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #2564 into master will decrease coverage by <.01%.
The diff coverage is 34.09%.

Impacted Files Coverage Δ
pkg/skaffold/trigger/triggers.go 30.95% <ø> (ø) ⬆️
pkg/skaffold/deploy/helm.go 64.31% <ø> (ø) ⬆️
pkg/skaffold/debug/debug.go 43.33% <ø> (ø) ⬆️
pkg/skaffold/build/cache/cache.go 55.81% <ø> (ø) ⬆️
pkg/skaffold/build/gcb/types.go 0% <ø> (ø) ⬆️
pkg/skaffold/docker/client.go 73.73% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/types.go 56.66% <ø> (ø) ⬆️
pkg/skaffold/docker/parse.go 87.36% <ø> (ø) ⬆️
pkg/skaffold/test/test.go 100% <ø> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 78.07% <ø> (ø) ⬆️
... and 12 more

@dgageot dgageot merged commit df7a920 into GoogleContainerTools:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants