Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the user specify a path and a secret name #2539

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Let the user specify a path and a secret name #2539

merged 1 commit into from
Jul 24, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 24, 2019

Fixes #2522

@dgageot
Copy link
Contributor Author

dgageot commented Jul 24, 2019

ping @priyawadhwa do you think it makes sense?

@priyawadhwa
Copy link
Contributor

priyawadhwa commented Jul 24, 2019 •
edited
Loading

makes sense to me! I think this should now match how we handle kaniko pull secrets, which is nice.

@dgageot dgageot merged commit 79370ee into GoogleContainerTools:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated kaniko secret generation for docker configuration used to work in v0.30.0 and now fails in v0.34.0
3 participants
@dgageot @priyawadhwa @googlebot