Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to kubectl and kustomize deployers #2537

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 24, 2019

  • Make both deployers look more the same
  • Add missing deploy failure event
  • Remove some duplication

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #2537 into master will increase coverage by 0.04%.
The diff coverage is 72.22%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/transformations.go 0% <0%> (ø)
pkg/skaffold/util/util.go 86.66% <100%> (+5.18%) ⬆️
pkg/skaffold/deploy/kubectl.go 72.5% <75%> (+0.54%) ⬆️
pkg/skaffold/deploy/kustomize.go 76.14% <77.77%> (-1.93%) ⬇️

@dgageot dgageot merged commit 7287f41 into GoogleContainerTools:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants