Set statuscheck to false. #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
balopat
reviewed
Jul 18, 2019
cmd/skaffold/app/cmd/flags.go
Outdated
| @@ -66,7 +66,7 @@ var FlagRegistry = []Flag{ | |||
| Shorthand: "n", | |||
| Usage: "Run deployments in the specified namespace", | |||
| Value: &opts.Namespace, | |||
| DefValue: "", | |||
| DefValue: "default", | |||
There was a problem hiding this comment.
let's separate this out to a different PR with tests and everything, I'm not sure about that this is what we want to do (we might but I need a bit more time to think it through).
There was a problem hiding this comment.
more thought around this: there is a difference between leaving it empty and letting the resources determine their namespace vs enforcing default.
…. This issue wont be seen
tejal29
changed the title
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn status-check false by default as a workaround for #2496 and #2495.