Simplify test debug #2399
Merged
Simplify test debug #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
requested review from
balopat,
briandealwis,
loosebazooka,
nkubala,
priyawadhwa and
tejal29
as code owners
briandealwis
reviewed
Jul 3, 2019
| defer stop() | ||
|
|
||
| client.WaitForPodsReady(test.pods...) | ||
| client.WaitForDeploymentsToStabilize(test.deployments...) |
There was a problem hiding this comment.
The jib example is a deployment.
There was a problem hiding this comment.
Not sure I understand your point
There was a problem hiding this comment.
By deleting this line, the deployments may not be stabilized before the test continues. Right?
There was a problem hiding this comment.
GetDeployment does it
| defer stop() | ||
|
|
||
| client.WaitForPodsReady(test.pods...) | ||
| client.WaitForDeploymentsToStabilize(test.deployments...) | ||
| for _, depName := range test.deployments { |
There was a problem hiding this comment.
Hmm this should be testing the pods too. I'll fix that separately.
|
BEFORE: AFTER: |
briandealwis
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2398