Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to Kaniko builder #2371

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Add a test to Kaniko builder #2371

merged 1 commit into from
Jul 1, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 28, 2019

Signed-off-by: David Gageot [email protected]

@codecov
Copy link

codecov bot commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #2371 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 76.34% <0%> (-2.16%) ⬇️
pkg/skaffold/docker/client.go 69.6% <0%> (-1.97%) ⬇️
pkg/skaffold/build/cluster/sources/sources.go 90.9% <0%> (+14.77%) ⬆️

@dgageot
Add a test to Kaniko builder
1aa7108 
Signed-off-by: David Gageot <[email protected]>
priyawadhwa
priyawadhwa approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dgageot dgageot merged commit e7d8cdc into GoogleContainerTools:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @priyawadhwa @googlebot