Bazel: support sub directories #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
chanseokoh,
loosebazooka,
nkubala,
priyawadhwa,
TadCordle and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
bazel-workspace
branch
12 times, most recently
from
6ca8d22 to
85d91af
Compare
dgageot
force-pushed
the
bazel-workspace
branch
2 times, most recently
from
25df53f to
60a0645
Compare
nkubala
reviewed
Jul 1, 2019
|
|
||
| parent := filepath.Dir(dir) | ||
| if parent == dir { | ||
| return "", errors.New("no git repository found") |
There was a problem hiding this comment.
should this message be something bazel-related instead of git-related?
There was a problem hiding this comment.
Lol. I’ll fix that tomorrow!
Fix GoogleContainerTools#2070 Signed-off-by: David Gageot <[email protected]>
|
@nkubala This is fixed now |
nkubala
approved these changes
Jul 2, 2019
balopat
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on this other PR: #2309
We use to only support Bazel projects with the WORKSPACE located in the artifact's workspace. Now, the artifact can be in a sub folder of the Bazel project.