Handle simple glob patterns when upgrading the sync patterns #2287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simple glob patterns are flattened at the destination. The translation to the new sync config was not handled correctly for cases such as:
Now, for compatible source patterns, the
strip
field is correctly populated. For example:IN:
OUT (
skaffold fix
):This requires also a simplification of the sync rule, if
strip
is a suffix ofdest
, which is now also applied to triple-star patterns.Fix #2280