Add K8sManagedBy function to labeller #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function will be used by the port forwarder to parse out deployed services to automatically port forward. I've added the defaultLabeller to the runner so that the label can be passed in to the port forwarder in an upcoming PR.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
balopat
suggested changes
Jun 17, 2019
pkg/skaffold/runner/labeller.go
Outdated
| @@ -51,3 +51,7 @@ func (d *DefaultLabeller) Labels() map[string]string { | |||
| K8ManagedByLabel: fmt.Sprintf("skaffold-%s", version), | |||
| } | |||
| } | |||
|
|
|||
| func (d *DefaultLabeller) K8sMangedByLabel() string { | |||
| return fmt.Sprintf("%s=skaffold-%s", K8ManagedByLabel, d.version) | |||
There was a problem hiding this comment.
This took me a while to understand - can we rename/refactor some things to make it clearer?
K8ManagedByLabel->K8sManagedByLabelKeyK8sMangedByLabel()->K8sManagedByLabelKeyValueString()fmt.Sprintf("skaffold-%s", version)->skaffoldVersion()and use that inK8sManagedByLabelKeyValueString()
There was a problem hiding this comment.
for sure, done!
priyawadhwa
force-pushed
the
default-labeller
branch
from
9d0380f
to
7863159
Compare
balopat
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will be used by the port forwarder to parse out deployed services to automatically port forward. I've added the defaultLabeller to the runner so that the label can be passed in to the port forwarder in an upcoming PR.