Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker is case sensitive about networks #2267

Conversation

tomaratyn
Copy link

host/bridge/none must be lower case or will be treated as network names.

host/bridge/none must be lower case or will be treated as network names.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dgageot dgageot self-requested a review June 14, 2019 00:38
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tomaratyn for submitting this PR!

To make sure it is merged you need two things:

  • First, you have to accept the CLA.
  • Second, you should not edit the json schemas directly. Those files are generated from comments on go structs in the pkg/skaffold/schema folder. So you have to modify all the places where there are those typos, then run make generate-schemas and finally commit those changes and update your PR.

@dgageot
Copy link
Contributor

dgageot commented Jun 20, 2019

Fixed with #2288. Thanks @tomaratyn for getting this started.

@dgageot dgageot closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants