Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop receiving the signals #2257

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Conversation

LexCC
Copy link
Contributor

@LexCC LexCC commented Jun 11, 2019

No description provided.

@nkubala
Copy link
Contributor

nkubala commented Jun 19, 2019

@jiejhih is there an issue that this change fixes? I think it's probably fine just wondering if you were running into a problem.

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jun 20, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #2257 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
+ Coverage   60.75%   60.76%   +<.01%     
==========================================
  Files         185      185              
  Lines        7808     7809       +1     
==========================================
+ Hits         4744     4745       +1     
  Misses       2678     2678              
  Partials      386      386
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/signals.go 72.22% <100%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8302bb...d6c600d. Read the comment docs.

@dgageot dgageot merged commit f82cd44 into GoogleContainerTools:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants