Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for local.NewBuilder #2240

Merged
merged 3 commits into from
Jun 8, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jun 8, 2019

Also improved a little bit the Override function to help when there is a mistake while using it in tests - originally it just threw a cryptic panic during teardown.

@codecov-io
Copy link

Codecov Report

Merging #2240 into master will increase coverage by 0.58%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2240      +/-   ##
==========================================
+ Coverage   60.03%   60.61%   +0.58%     
==========================================
  Files         185      185              
  Lines        7794     7798       +4     
==========================================
+ Hits         4679     4727      +48     
+ Misses       2728     2683      -45     
- Partials      387      388       +1
Impacted Files Coverage Δ
pkg/skaffold/build/local/types.go 61.76% <100%> (+8.63%) ⬆️
pkg/skaffold/runner/diagnose.go 13.04% <0%> (+13.04%) ⬆️
pkg/skaffold/kubernetes/wait.go 46.05% <0%> (+46.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca710f...7c9f88a. Read the comment docs.

@dgageot dgageot merged commit bbcb1a5 into GoogleContainerTools:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants