Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #2225

Merged
merged 6 commits into from
Jun 6, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 6, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #2225 into master will increase coverage by 0.6%.
The diff coverage is 68.42%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2225     +/-   ##
========================================
+ Coverage    58.1%   58.7%   +0.6%     
========================================
  Files         188     188             
  Lines        7869    7849     -20     
========================================
+ Hits         4572    4608     +36     
+ Misses       2924    2873     -51     
+ Partials      373     368      -5
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/wait.go 0% <0%> (ø) ⬆️
pkg/skaffold/kubernetes/watcher.go 100% <100%> (+100%) ⬆️
pkg/skaffold/util/util.go 77.03% <0%> (+1.48%) ⬆️
pkg/skaffold/runner/runner.go 70.73% <0%> (+1.62%) ⬆️
pkg/skaffold/util/tar.go 40.47% <0%> (+4.76%) ⬆️
cmd/skaffold/app/cmd/runner.go 52.63% <0%> (+5.26%) ⬆️
pkg/skaffold/test/test.go 100% <0%> (+12.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d676b...2ffe71c. Read the comment docs.

Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot merged commit 5e7a25f into GoogleContainerTools:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants