Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify schema upgrades: remove duplication #2212

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 3, 2019

Signed-off-by: David Gageot [email protected]

@codecov-io
Copy link

Codecov Report

Merging #2212 into master will increase coverage by 0.05%.
The diff coverage is 64.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2212      +/-   ##
=========================================
+ Coverage   58.55%   58.6%   +0.05%     
=========================================
  Files         188     188              
  Lines        7882    7805      -77     
=========================================
- Hits         4615    4574      -41     
+ Misses       2877    2859      -18     
+ Partials      390     372      -18
Impacted Files Coverage Δ
pkg/skaffold/schema/v1beta8/upgrade.go 63.63% <0%> (+5.42%) ⬆️
pkg/skaffold/schema/v1beta10/upgrade.go 100% <100%> (+33.33%) ⬆️
pkg/skaffold/schema/v1beta7/upgrade.go 100% <100%> (+33.33%) ⬆️
pkg/skaffold/schema/v1alpha5/upgrade.go 100% <100%> (+29.62%) ⬆️
pkg/skaffold/schema/v1alpha4/upgrade.go 100% <100%> (+36.36%) ⬆️
pkg/skaffold/util/util.go 75.55% <42.85%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b139240...8929dd5. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@balopat balopat merged commit c2ba29e into GoogleContainerTools:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants