Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kind to run integration tests on TravisCI #2196

Merged
merged 2 commits into from
Jun 8, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 29, 2019

This is a first try at using kind for our integration tests.

  • It creates a kind cluster in Travis.
  • It runs the test suite in the same container that's currently used on kokoro.
  • I had to add a few lines of code in skaffold to handle kind clusters. The main change is that docker images have to be explicitly loaded before they are used by a k8s workload.

@dgageot dgageot marked this pull request as ready for review May 29, 2019 11:43
@dgageot dgageot force-pushed the kind branch 5 times, most recently from b93e603 to 0ef336c Compare June 1, 2019 19:11
@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #2196 into master will decrease coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
- Coverage   58.55%   58.52%   -0.03%     
==========================================
  Files         188      188              
  Lines        7882     7890       +8     
==========================================
+ Hits         4615     4618       +3     
- Misses       2877     2881       +4     
- Partials      390      391       +1
Impacted Files Coverage Δ
pkg/skaffold/runner/build.go 54.16% <0%> (-14.26%) ⬇️
cmd/skaffold/app/cmd/config/util.go 59.16% <100%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b139240...175a7ce. Read the comment docs.

@dgageot dgageot force-pushed the kind branch 9 times, most recently from ae5d0ab to d738cc4 Compare June 2, 2019 17:18
@dgageot
Copy link
Contributor Author

dgageot commented Jun 3, 2019

@tejal29 @balopat @nkubala This PR is ready to be reviewed. Be aware that it doesn't run all the tests we used to run on kokoro. Because it has no gcp credentials, it can't use cloud build or have kaniko push to gcr. Tell me what you think

@dgageot dgageot changed the title [WIP] Use kind to run integration tests on TravisCI Use kind to run integration tests on TravisCI Jun 3, 2019
@dgageot dgageot force-pushed the kind branch 7 times, most recently from f6f8368 to 46935b6 Compare June 5, 2019 14:06
@dgageot dgageot force-pushed the kind branch 3 times, most recently from 165c97d to 6450152 Compare June 6, 2019 19:56
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's start using this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants