Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test helper to make tests less verbose #2193

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 29, 2019

What do you think of such test helper?

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2193   +/-   ##
=======================================
  Coverage   58.14%   58.14%           
=======================================
  Files         188      188           
  Lines        7863     7863           
=======================================
  Hits         4572     4572           
  Misses       2919     2919           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65999c7...14cd8b5. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's pretty cool to fold our test utilities into a testing.T like structure.

@dgageot dgageot merged commit 3088a8f into GoogleContainerTools:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants