-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print logs from init containers #2182
Print logs from init containers #2182
Conversation
Signed-off-by: Cornelius Weig <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@ottonello Looks like you need to explicitly express your consent that my additional changes are ok (https://opensource.google.com/docs/cla/#github-consent). |
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
==========================================
- Coverage 57.41% 57.39% -0.03%
==========================================
Files 187 187
Lines 7905 7908 +3
==========================================
Hits 4539 4539
- Misses 2954 2957 +3
Partials 412 412
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Should this address the concerns in #1865 ? I got stuck at trying to write some integration tests, none of them were really ready for testing something like this.
@ottonello I totally missed that there were other issues with the original PR. I'll try to set up an integration test for logs from init containers. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Thanks @corneliusweig for taking this up again. Running kokoro now. |
This is based on #1865, but now skips terminated containers.
Close #1865.
CC @tejal29 who raised this concern on #1865 and @ottonello who opened #1865 .