Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cmd builder #2179

Merged
merged 5 commits into from
Jun 3, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 27, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #2179 into master will decrease coverage by 0.04%.
The diff coverage is 96.51%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2179      +/-   ##
=========================================
- Coverage   58.55%   58.5%   -0.05%     
=========================================
  Files         188     188              
  Lines        7882    7869      -13     
=========================================
- Hits         4615    4604      -11     
+ Misses       2877    2876       -1     
+ Partials      390     389       -1
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/config/set.go 71.01% <0%> (-3.02%) ⬇️
cmd/skaffold/app/cmd/config/list.go 0% <0%> (-25.81%) ⬇️
cmd/skaffold/app/cmd/config/unset.go 15.38% <0%> (-32.24%) ⬇️
cmd/skaffold/app/cmd/deploy.go 64.28% <100%> (-4.47%) ⬇️
cmd/skaffold/app/cmd/config.go 100% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/dev.go 22.72% <100%> (-1.72%) ⬇️
cmd/skaffold/app/cmd/init.go 55% <100%> (-2.15%) ⬇️
cmd/skaffold/app/cmd/diagnose.go 35% <100%> (-3.1%) ⬇️
cmd/skaffold/app/cmd/debug.go 54.54% <100%> (-7%) ⬇️
cmd/skaffold/app/cmd/fix.go 67.74% <100%> (-1.01%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b139240...3444f35. Read the comment docs.

@dgageot dgageot merged commit 81a56b1 into GoogleContainerTools:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants