Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication around cobra code. #2145

Merged
merged 1 commit into from
May 17, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 17, 2019

Signed-off-by: David Gageot [email protected]

@dgageot dgageot marked this pull request as ready for review May 17, 2019 09:29
@codecov-io
Copy link

Codecov Report

Merging #2145 into master will increase coverage by 0.44%.
The diff coverage is 82.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
+ Coverage   56.31%   56.76%   +0.44%     
==========================================
  Files         180      181       +1     
  Lines        7815     7829      +14     
==========================================
+ Hits         4401     4444      +43     
+ Misses       2994     2976      -18     
+ Partials      420      409      -11
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/diagnose.go 34.78% <100%> (+4.01%) ⬆️
cmd/skaffold/app/cmd/cmd.go 75.65% <100%> (+1.39%) ⬆️
cmd/skaffold/app/cmd/commands/commands.go 100% <100%> (ø)
cmd/skaffold/app/cmd/build.go 74.35% <100%> (+5.31%) ⬆️
cmd/skaffold/app/cmd/config/flags.go 100% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/config/unset.go 47.61% <53.84%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 57.14% <55%> (+2.59%) ⬆️
cmd/skaffold/app/cmd/config/set.go 74.02% <58.33%> (ø) ⬆️
cmd/skaffold/app/cmd/run.go 42.85% <72.72%> (+5.35%) ⬆️
cmd/skaffold/app/cmd/version.go 77.77% <75%> (+31.62%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010c517...a8358f9. Read the comment docs.

@nkubala nkubala merged commit e6f08c1 into GoogleContainerTools:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants