More tests #2128
Merged
More tests #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
dgageot
force-pushed
the
more-tests
branch
3 times, most recently
from
4d4bdda to
b190fbf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2128 +/- ##
========================================
+ Coverage 56.79% 57.3% +0.5%
========================================
Files 183 182 -1
Lines 7890 7869 -21
========================================
+ Hits 4481 4509 +28
+ Misses 2995 2948 -47
+ Partials 414 412 -2
Continue to review full report at Codecov.
|
nkubala
reviewed
May 15, 2019
| return append(s[:i], s[i+1:]...) | ||
| for i := len(s) - 1; i >= 0; i-- { | ||
| if s[i] == target { | ||
| s = append(s[:i], s[i+1:]...) |
There was a problem hiding this comment.
😳 was this causing bugs anywhere?
There was a problem hiding this comment.
I don’t think so. I added tests and realized it was doing the job only partially
| @@ -91,8 +91,7 @@ func (r *SkaffoldRunner) Dev(ctx context.Context, out io.Writer, artifacts []*la | |||
| // Watch artifacts | |||
| for i := range artifacts { | |||
| artifact := artifacts[i] | |||
|
|
|||
| if !r.IsTargetImage(artifact) { | |||
| if !r.runCtx.Opts.IsTargetImage(artifact) { | |||
There was a problem hiding this comment.
this was broken before then?
There was a problem hiding this comment.
No. I just moved the function
|
This needs a rebase :) |
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
It’s now easier to understand what the pod spec looks like. Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
|
@nkubala @priyawadhwa It has been rebased |
nkubala
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.