Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic for nil pod watch object #2112

Merged
merged 1 commit into from
May 14, 2019
Merged

Don't panic for nil pod watch object #2112

merged 1 commit into from
May 14, 2019

Conversation

tbarrella
Copy link
Contributor

to fix #2103

@codecov-io
Copy link

Codecov Report

Merging #2112 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   56.29%   56.28%   -0.02%     
==========================================
  Files         180      180              
  Lines        7794     7796       +2     
==========================================
  Hits         4388     4388              
- Misses       2989     2991       +2     
  Partials      417      417
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/wait.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d01b1...ca057fe. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label May 13, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 13, 2019
@balopat balopat merged commit aa059bd into GoogleContainerTools:master May 14, 2019
@balopat
Copy link
Contributor

balopat commented May 14, 2019

Thank you for your contribution!

@tbarrella
Copy link
Contributor Author

(Thank you! I'm a big fan of Skaffold and everyone's work on it; wish I could contribute more)

@tbarrella tbarrella deleted the build-panic branch May 15, 2019 02:42
@priyawadhwa
Copy link
Contributor

@tbarrella if you're interested in contributing more, here's a list of good first issues, and possibly more complicated issues we'd love some help with here!

@tbarrella
Copy link
Contributor Author

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic during Kaniko build
6 participants