add explanation to cloud build section docs #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explanation to google cloud build section docs to make clear the differences between the gcloud command and the skaffold build process with GCB. This fixes #1998
panitaxx
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
=======================================
Coverage 56.29% 56.29%
=======================================
Files 180 180
Lines 7794 7794
=======================================
Hits 4388 4388
Misses 2989 2989
Partials 417 417Continue to review full report at Codecov.
|
balopat
reviewed
May 10, 2019
Co-Authored-By: Balint Pato <[email protected]>
balopat
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explanation to google cloud build section docs to make clear the
differences between the gcloud command and the skaffold build process with GCB.
This fixes #1998