-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to custom artifact dependencies #2095
Conversation
Allow users to specify a command to execute to determine dependencies for a custom artifact. Dependencies must be returned as a valid JSON array.
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
=========================================
+ Coverage 56.18% 56.2% +0.02%
=========================================
Files 180 180
Lines 7771 7784 +13
=========================================
+ Hits 4366 4375 +9
- Misses 2988 2990 +2
- Partials 417 419 +2
Continue to review full report at Codecov.
|
Please visit http://35.236.49.15:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor docs comments
Allow users to specify a command to execute to determine dependencies
for a custom artifact. Dependencies must be returned as a valid JSON
array.
Now, this is valid: