Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to custom artifact dependencies #2095

Merged
merged 4 commits into from
May 9, 2019

Conversation

priyawadhwa
Copy link
Contributor

Allow users to specify a command to execute to determine dependencies
for a custom artifact. Dependencies must be returned as a valid JSON
array.

Now, this is valid:

custom:
  buildCommand: ./build.sh
  dependencies:
    command: echo ["file1","file2","file3"]

Priya Wadhwa added 2 commits May 8, 2019 13:43
Allow users to specify a command to execute to determine dependencies
for a custom artifact. Dependencies must be returned as a valid JSON
array.
@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #2095 into master will increase coverage by 0.02%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2095      +/-   ##
=========================================
+ Coverage   56.18%   56.2%   +0.02%     
=========================================
  Files         180     180              
  Lines        7771    7784      +13     
=========================================
+ Hits         4366    4375       +9     
- Misses       2988    2990       +2     
- Partials      417     419       +2
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/validation/validation.go 96.29% <100%> (ø) ⬆️
pkg/skaffold/build/custom/dependencies.go 75% <60%> (-10.72%) ⬇️
pkg/skaffold/runner/labeller.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a117236...4db921f. Read the comment docs.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label May 9, 2019
@container-tools-bot
Copy link

Please visit http://35.236.49.15:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label May 9, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor docs comments

@balopat balopat merged commit 1a2d5b0 into GoogleContainerTools:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants