Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deploying remote helm charts #2058

Merged
merged 5 commits into from
May 21, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented May 2, 2019

Fixes #1615

this adds a boolean remote field to the releases stanza of helm deploys in the skaffold config. it's used when computing the dependencies for a helm release: if a chart path is specified as remote, skaffold will skip it when listing the dependencies for the deploy.

deploy:
  helm:
    releases:
      - name: redis
        chartPath: stable/redis
        remote: true
        skipBuildDependencies: true // not necessary when `remote:true` is specified

since dependency building doesn't make sense for remote helm charts (e.g. helm dep build stable/redis doesn't work), we skip this by default when remote: true is specified by the user.

remote: true ==> skipBuildDependencies: true

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

pkg/skaffold/deploy/helm.go Outdated Show resolved Hide resolved
tejal29
tejal29 previously requested changes May 2, 2019
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests which return no dependencies for remote charts?

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat dismissed tejal29’s stale review May 21, 2019 17:37

the tests are added

@nkubala nkubala merged commit d048cdd into GoogleContainerTools:master May 21, 2019
@nkubala nkubala deleted the remote-helm branch May 21, 2019 17:44
@dahovey
Copy link
Contributor

dahovey commented May 23, 2019

This is a feature I need for development, but I'm not familiar with building a go project and I need a Windows binary. Are there edge builds available somewhere?

@dahovey
Copy link
Contributor

dahovey commented May 24, 2019

I see this was just released today. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold dev does not work with remote Helm charts
6 participants