-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deploying remote helm charts #2058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some tests which return no dependencies for remote charts?
Co-Authored-By: Balint Pato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a feature I need for development, but I'm not familiar with building a go project and I need a Windows binary. Are there edge builds available somewhere? |
I see this was just released today. Thank you!! |
Fixes #1615
this adds a boolean
remote
field to thereleases
stanza ofhelm
deploys in the skaffold config. it's used when computing the dependencies for a helm release: if a chart path is specified asremote
, skaffold will skip it when listing the dependencies for the deploy.since dependency building doesn't make sense for remote helm charts (e.g.
helm dep build stable/redis
doesn't work), we skip this by default whenremote: true
is specified by the user.remote: true
==>skipBuildDependencies: true