fix show some option in skaffold delete #1995 #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u5surf
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
+ Coverage 55.48% 55.49% +0.01%
==========================================
Files 173 173
Lines 7510 7512 +2
==========================================
+ Hits 4167 4169 +2
Misses 2952 2952
Partials 391 391
Continue to review full report at Codecov.
|
tejal29
added
good first issue
tejal29
reviewed
Apr 22, 2019
| @@ -142,6 +142,19 @@ func FlagToEnvVarName(f *pflag.Flag) string { | |||
| return fmt.Sprintf("SKAFFOLD_%s", strings.Replace(strings.ToUpper(f.Name), "-", "_", -1)) | |||
| } | |||
|
|
|||
| func AddRunDeleteFlags(cmd *cobra.Command) { | |||
| cmd.Flags().BoolVar(&opts.EnableRPC, "enable-rpc", false, "Enable gRPC for exposing Skaffold events (true by default for `skaffold dev`)") | |||
| cmd.Flags().IntVar(&opts.RPCPort, "rpc-port", constants.DefaultRPCPort, "tcp port to expose event API") | |||
There was a problem hiding this comment.
Can you move these flags to AddCommonFlags ?
AddRunDevFlags(cmd *cobra.Command) {
AddRunCommonDevFlags(cmd)
cmd.Flags().BoolVar(&opts.CacheArtifacts, "cache-artifacts", false, "Set to true to enable caching of artifacts.")
cmd.Flags().StringVarP(&opts.CacheFile, "cache-file", "", "", "Specify the location of the cache file (default $HOME/.skaffold/cache)")
}
tejal29
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1995