Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for local development setups #1970

Merged

Conversation

corneliusweig
Copy link
Contributor

Close #1957

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

The essential steps are:

1. Ensure that Skaffold builds the images with the docker daemon, which also runs the containers.
2. Tell Skaffold to skip pushing images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this as a step 3 below?

  1. Tell skaffold to skip pushing images by adding push:false to your skaffold config:
build:
  local:
   push: false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. This is should be mentioned as an alternative to the skaffold config set -k context local-cluster true setting.

@codecov-io
Copy link

Codecov Report

Merging #1970 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1970      +/-   ##
==========================================
+ Coverage   52.59%   52.94%   +0.35%     
==========================================
  Files         182      183       +1     
  Lines        7893     7920      +27     
==========================================
+ Hits         4151     4193      +42     
+ Misses       3352     3327      -25     
- Partials      390      400      +10
Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 74.54% <0%> (-9.33%) ⬇️
pkg/skaffold/util/util.go 64.92% <0%> (-3.05%) ⬇️
pkg/skaffold/util/config.go 68.42% <0%> (ø)
cmd/skaffold/app/cmd/config/util.go 58.11% <0%> (+4.27%) ⬆️
pkg/skaffold/schema/versions.go 74.35% <0%> (+5.12%) ⬆️
pkg/skaffold/update/update.go 52.17% <0%> (+26.08%) ⬆️
cmd/skaffold/app/cmd/runner.go 56.25% <0%> (+56.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc22668...f8978b2. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Apr 17, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 17, 2019
@priyawadhwa priyawadhwa added the docs-modifications runs the docs preview service on the given PR label Apr 17, 2019
@container-tools-bot
Copy link

Please visit http://35.236.122.247:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Apr 17, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@priyawadhwa priyawadhwa merged commit c49bf00 into GoogleContainerTools:master Apr 17, 2019
@corneliusweig corneliusweig deleted the local-setup-doc branch April 17, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for non-standard local setups
6 participants