-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for local development setups #1970
Add documentation for local development setups #1970
Conversation
Signed-off-by: Cornelius Weig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
The essential steps are: | ||
|
||
1. Ensure that Skaffold builds the images with the docker daemon, which also runs the containers. | ||
2. Tell Skaffold to skip pushing images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add this as a step 3 below?
- Tell skaffold to skip pushing images by adding
push:false
to your skaffold config:
build:
local:
push: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. This is should be mentioned as an alternative to the skaffold config set -k context local-cluster true
setting.
Signed-off-by: Cornelius Weig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
+ Coverage 52.59% 52.94% +0.35%
==========================================
Files 182 183 +1
Lines 7893 7920 +27
==========================================
+ Hits 4151 4193 +42
+ Misses 3352 3327 -25
- Partials 390 400 +10
Continue to review full report at Codecov.
|
Please visit http://35.236.122.247:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this!
Close #1957