Validate pipeline config #1881
Merged
Validate pipeline config #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1881 +/- ##
==========================================
+ Coverage 51.45% 51.72% +0.26%
==========================================
Files 171 172 +1
Lines 7690 7735 +45
==========================================
+ Hits 3957 4001 +44
- Misses 3357 3358 +1
Partials 376 376
Continue to review full report at Codecov.
|
|
Awesome, thank you! Will have a deeper look tomorrow. |
|
bunch of errors on integration tests: |
|
@balopat My bad, forgot that some structs may have no fields. |
balopat
reviewed
Mar 27, 2019
balopat
reviewed
Mar 27, 2019
balopat
reviewed
Mar 27, 2019
balopat
reviewed
Mar 27, 2019
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
corneliusweig
force-pushed
the
validate-pipeline-config
branch
from
d79df76 to
e2eab9d
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@balopat nits are done. I also added one more commit, moving the validation down after profile application. It occured to me that this could also create |
Fields annotated with 'oneOf' should only be specified once by the user. If conflicting fields are set for a given struct, Skaffold fails with an error. Fix validation for structs without fields Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
force-pushed
the
validate-pipeline-config
branch
from
a9fac45 to
b3fb291
Compare
balopat
approved these changes
Apr 2, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields annotated with 'oneOf' should only be specified once by the user. If conflicting fields are set for a given struct, Skaffold now fails with an error.
Close #1836