Fix skaffold build templating output and add tests #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1841 +/- ##
==========================================
+ Coverage 49.18% 50.16% +0.97%
==========================================
Files 166 168 +2
Lines 7287 7356 +69
==========================================
+ Hits 3584 3690 +106
+ Misses 3357 3310 -47
- Partials 346 356 +10
Continue to review full report at Codecov.
|
tejal29
force-pushed
the
deploy_build
branch
2 times, most recently
from
61e6257 to
e47c5fa
Compare
dgageot
suggested changes
Mar 21, 2019
cmd/skaffold/app/cmd/build.go
Outdated
| } | ||
| } | ||
| if err != nil { | ||
| return nil, func() { cancel() }, errors.Wrap(err, "creating runner") |
There was a problem hiding this comment.
Could you return cancel instead of func() { cancel() }?
dgageot
suggested changes
Mar 22, 2019
dgageot
suggested changes
Mar 23, 2019
dgageot
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1839
In this commit
skaffold build -ois only useful with --quiet.skaffold build --quiet > build.outoutput can consumed to byskaffold deployto correctly parse and construct a build.Artifacts object.