Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a design proposal template and README. #1838

Merged
merged 10 commits into from
Apr 1, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Mar 20, 2019

This PR is to add design proposal template.

This template can help the core team to get a better understanding of the new feature or any big changes.
Also can serve as a guideline to follow when reviewing big changes.

@codecov-io
Copy link

Codecov Report

Merging #1838 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1838   +/-   ##
=======================================
  Coverage   47.98%   47.98%           
=======================================
  Files         143      143           
  Lines        6483     6483           
=======================================
  Hits         3111     3111           
  Misses       3089     3089           
  Partials      283      283

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8418c9e...c11533e. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #1838 into master will increase coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
+ Coverage    49.9%   51.45%   +1.55%     
==========================================
  Files         168      171       +3     
  Lines        7354     7690     +336     
==========================================
+ Hits         3670     3957     +287     
- Misses       3328     3357      +29     
- Partials      356      376      +20
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl.go 68.05% <0%> (-6.19%) ⬇️
cmd/skaffold/app/cmd/dev.go 10.09% <0%> (-3.19%) ⬇️
pkg/skaffold/deploy/helm.go 61.92% <0%> (ø) ⬆️
pkg/skaffold/schema/versions.go 65.85% <0%> (ø) ⬆️
pkg/skaffold/event/proto/skaffold.pb.go 5.95% <0%> (ø) ⬆️
pkg/skaffold/schema/v1beta7/config.go
pkg/skaffold/schema/v1beta7/upgrade.go
pkg/skaffold/debug/transform.go 86.2% <0%> (ø)
pkg/skaffold/debug/transform_nodejs.go 82.75% <0%> (ø)
pkg/skaffold/debug/transform_jvm.go 94.84% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77c062...3cf696a. Read the comment docs.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for being grammar police 👮‍♂️

Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nits

@tejal29 tejal29 force-pushed the add_design_doc_proposal branch from bffd129 to 551dbe3 Compare March 26, 2019 16:56
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Mar 26, 2019
@balopat balopat self-assigned this Mar 26, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the lead on this!
First round of nits added. I'll do another round of review soon.

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Mar 26, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 1, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 1, 2019
@tejal29 tejal29 merged commit 05e15dd into GoogleContainerTools:master Apr 1, 2019
@tejal29 tejal29 mentioned this pull request Apr 12, 2019
@tejal29 tejal29 deleted the add_design_doc_proposal branch September 18, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants