-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a design proposal template and README. #1838
Adding a design proposal template and README. #1838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
=======================================
Coverage 47.98% 47.98%
=======================================
Files 143 143
Lines 6483 6483
=======================================
Hits 3111 3111
Misses 3089 3089
Partials 283 283 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
==========================================
+ Coverage 49.9% 51.45% +1.55%
==========================================
Files 168 171 +3
Lines 7354 7690 +336
==========================================
+ Hits 3670 3957 +287
- Misses 3328 3357 +29
- Partials 356 376 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for being grammar police 👮♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only nits
bffd129
to
551dbe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking the lead on this!
First round of nits added. I'll do another round of review soon.
Co-Authored-By: tejal29 <[email protected]>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-Authored-By: tejal29 <[email protected]>
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…skaffold into add_design_doc_proposal
This PR is to add design proposal template.
This template can help the core team to get a better understanding of the new feature or any big changes.
Also can serve as a guideline to follow when reviewing big changes.