Basic unit test to go through all the cobra related code #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
dgageot
force-pushed
the
basic-cobra-test
branch
from
0ceec9a
to
c7c81d6
Compare
tejal29
reviewed
Mar 19, 2019
| testutil.CheckError(t, false, err) | ||
| testutil.CheckContains(t, "Available Commands", output.String()) | ||
| testutil.CheckDeepEqual(t, "", errOutput.String()) | ||
| } |
There was a problem hiding this comment.
Can we also have a test case for invalid command and see if error is returned.
There was a problem hiding this comment.
@tejal29 woot! Discovered a race condition thanks to this test
Codecov Report
@@ Coverage Diff @@
## master #1835 +/- ##
==========================================
- Coverage 47.98% 47.91% -0.08%
==========================================
Files 143 144 +1
Lines 6483 6499 +16
==========================================
+ Hits 3111 3114 +3
- Misses 3089 3101 +12
- Partials 283 284 +1
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
basic-cobra-test
branch
from
c7c81d6
to
76717ae
Compare
tejal29
reviewed
Mar 20, 2019
cmd/skaffold/app/cmd/cmd.go
Outdated
| rootCmd.PersistentPreRunE = func(cmd *cobra.Command, args []string) error { | ||
| if err := SetUpLogs(err, v); err != nil { | ||
| return err | ||
| } | ||
| rootCmd.SilenceUsage = true | ||
| logrus.Infof("Skaffold %+v", version.Get()) | ||
|
|
||
| // Avoid race condition |
There was a problem hiding this comment.
Can you describe what race condition is it avoiding for dummies like me?
There was a problem hiding this comment.
I'm going to simplify the code so that this is not needed anymore.
tejal29
approved these changes
Mar 20, 2019
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
basic-cobra-test
branch
from
f2ec08d
to
c48c484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot [email protected]