Add tests for skaffold init walk flow. #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
tejal29
force-pushed
the
refactor_walk
branch
3 times, most recently
from
7174184 to
ace4a83
Compare
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
=========================================
+ Coverage 49.21% 49.52% +0.3%
=========================================
Files 166 166
Lines 7293 7298 +5
=========================================
+ Hits 3589 3614 +25
+ Misses 3355 3335 -20
Partials 349 349
Continue to review full report at Codecov.
|
balopat
added
kokoro:run
balopat
reviewed
Mar 18, 2019
balopat
reviewed
Mar 18, 2019
balopat
reviewed
Mar 18, 2019
balopat
reviewed
Mar 18, 2019
dgageot
suggested changes
Mar 19, 2019
dgageot
suggested changes
Mar 19, 2019
dgageot
suggested changes
Mar 21, 2019
In this change: 1. Refactor walk into its own function 2. Add sample directory structure and tests.
dgageot
reviewed
Mar 22, 2019
| t.Run(test.description, func(t *testing.T) { | ||
| testDir, cleanUp := testutil.NewTempDir(t) | ||
| rootDir := testDir.Root() | ||
| defer cleanUp() |
There was a problem hiding this comment.
nit: defer cleanUp() should always be called as soon as we get the cleanup
dgageot
approved these changes
Mar 22, 2019
|
@tejal29 approved with a nits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we support other helm and kustomize deployers in
skaffold initflow, walk will become more complex.Refactoring it out and adding some tests.