Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster doc preview #1773

Merged
merged 5 commits into from
Mar 15, 2019
Merged

Faster doc preview #1773

merged 5 commits into from
Mar 15, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 11, 2019

Clone the docs theme inside a Docker image, not on the developer's machine.
Instead of mounting the whole workspace, we mount only the relevant doc sources.

This makes working on the documentation much faster, gets rid of the submodules, doesn't require a cleanup phase...

Signed-off-by: David Gageot [email protected]

@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Mar 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #1773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1773   +/-   ##
======================================
  Coverage      47%     47%           
======================================
  Files         130     130           
  Lines        6270    6270           
======================================
  Hits         2947    2947           
  Misses       3021    3021           
  Partials      302     302

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6332732...6a99643. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #1773 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1773      +/-   ##
==========================================
- Coverage   46.09%   45.48%   -0.61%     
==========================================
  Files         142      142              
  Lines        6576     6617      +41     
==========================================
- Hits         3031     3010      -21     
- Misses       3242     3306      +64     
+ Partials      303      301       -2
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/wait.go 0% <0%> (-28.09%) ⬇️
pkg/skaffold/build/cache/retrieve.go 86.92% <0%> (-1.18%) ⬇️
pkg/skaffold/runner/runner.go 60.09% <0%> (-0.76%) ⬇️
integration/util.go 0% <0%> (ø) ⬆️
pkg/skaffold/plugin/builders/docker/local.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aae6af...67a26be. Read the comment docs.

@dgageot dgageot added docs-modifications runs the docs preview service on the given PR and removed docs-modifications runs the docs preview service on the given PR labels Mar 11, 2019
@dgageot dgageot force-pushed the faster-doc branch 2 times, most recently from 62043c6 to b81b8ca Compare March 11, 2019 20:29
@balopat balopat self-assigned this Mar 11, 2019
@balopat balopat added docs-modifications runs the docs preview service on the given PR and removed docs-modifications runs the docs preview service on the given PR labels Mar 11, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 12, 2019
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552354051589765559 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 12, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 12, 2019
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552408383884423507 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 12, 2019
@dgageot dgageot added the wip label Mar 12, 2019
Clone the docs theme inside a Docker image

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Mar 13, 2019
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552495638900096503 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 13, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 14, 2019
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552585047209341248 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 14, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 14, 2019
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552599771549367324 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 14, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 15, 2019
@container-tools-bot
Copy link

Please visit http://35.235.98.149:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 15, 2019
@balopat balopat removed the wip label Mar 15, 2019
@balopat balopat self-requested a review March 15, 2019 23:02
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Mar 15, 2019
@container-tools-bot
Copy link

Please visit http://35.236.109.79:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 15, 2019
@balopat balopat merged commit ba77865 into GoogleContainerTools:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants