-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster doc preview #1773
Faster doc preview #1773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
======================================
Coverage 47% 47%
======================================
Files 130 130
Lines 6270 6270
======================================
Hits 2947 2947
Misses 3021 3021
Partials 302 302 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
- Coverage 46.09% 45.48% -0.61%
==========================================
Files 142 142
Lines 6576 6617 +41
==========================================
- Hits 3031 3010 -21
- Misses 3242 3306 +64
+ Partials 303 301 -2
Continue to review full report at Codecov.
|
62043c6
to
b81b8ca
Compare
Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552354051589765559 to view logs. |
Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552408383884423507 to view logs. |
Clone the docs theme inside a Docker image Signed-off-by: David Gageot <[email protected]>
Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552495638900096503 to view logs. |
Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552585047209341248 to view logs. |
Error creating deployment docs-controller-deployment-1773, please visit https://storage.googleapis.com/webhook-logs/logs-1773-1552599771549367324 to view logs. |
Please visit http://35.235.98.149:1313 to view changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please visit http://35.236.109.79:1313 to view changes to the docs. |
Clone the docs theme inside a Docker image, not on the developer's machine.
Instead of mounting the whole workspace, we mount only the relevant doc sources.
This makes working on the documentation much faster, gets rid of the submodules, doesn't require a cleanup phase...
Signed-off-by: David Gageot [email protected]