Add support for ECR pod specs for kaniko

[azaiter]

This PR adds support for proper ECR pod specs for kaniko. Previously, Kaniko pod template didn't have proper environment variables and volume mounts to have it working properly.

Kinda related issue: #731

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[azaiter]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[codecov-io]

Codecov Report

Merging #1700 into master will decrease coverage by 0.02%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
- Coverage   46.55%   46.53%   -0.03%     
==========================================
  Files         125      125              
  Lines        5664     5669       +5     
==========================================
+ Hits         2637     2638       +1     
- Misses       2754     2758       +4     
  Partials      273      273

Impacted Files	Coverage Δ
pkg/skaffold/runner/timings.go	15% <0%> (-0.39%)	⬇️
pkg/skaffold/schema/defaults/defaults.go	38.15% <25%> (-0.36%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64a0ed...edf99a2. Read the comment docs.

[tejal29]

Thank You @azaiter for this PR.
Before we move forward, there is another PR floating around, where we move PullSecret (by default GAC) to something like this:

  kaniko:
    buildContext: 
      googleCloudConfig:
        secretName: e2esecret

Maybe we should support a configurable way to specify

1. What Container Registry this is
2. And then secret name.
   Instead of having isECR, isSomeOtherRegistry and have branches.
   Would you be open to collaborate with @venkatk-25 to come up with a design proposal for this?

[venkatk-25]

Created a new proposal https://docs.pivotal.io/pivotalcf/2-0/pcf-release-notes/runtime-rn.html#2.0.22 . Please give suggestions/comments

[tejal29]

Created a new proposal https://docs.pivotal.io/pivotalcf/2-0/pcf-release-notes/runtime-rn.html#2.0.22 . Please give suggestions/comments

@venkatk-25 i think the link "https://docs.pivotal.io/pivotalcf/2-0/pcf-release-notes/runtime-rn.html#2.0.22 is incorrect, you meant to post #1892 ?
Also, can we capture all of this in an actual document? Its easy for commenting VS a github issue and will remain in the git history.

[dgageot]

Hi @azaiter this PR seems to be stalled for quite some time. Would you like to update it?

[dgageot]

I'm going to close this PR because of the lack of activity. I'm sorry we couldn't get this merged in. Please feel free to reopen, we'll be more that happy to help get this done!

[azaiter]

Sorry, I've been super busy last week. Since @venkatk-25 raised a design proposal based on @tejal29 's suggestion to generalize the approach towards setting env vars and mounting files to Kaniko pod, in addition to #1906 PR that actually does that, I think this PR is no longer the optimal approach unless if you see something that is worth building upon from this PR, in which I'm also more happy to help (time permitting). Thanks!