Diagnose skaffold.yaml #1686
Merged
Diagnose skaffold.yaml #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Also let the user specify a profile Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
diagnose-config
branch
from
887e9c7 to
45f27d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
==========================================
- Coverage 46.69% 46.64% -0.05%
==========================================
Files 123 123
Lines 5600 5606 +6
==========================================
Hits 2615 2615
- Misses 2716 2722 +6
Partials 269 269
Continue to review full report at Codecov.
|
balopat
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also let the user specify a profile
Signed-off-by: David Gageot [email protected]