Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate skaffold references #1675

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 20, 2019

No description provided.

@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #1675 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
+ Coverage   47.46%   47.48%   +0.01%     
==========================================
  Files         122      122              
  Lines        5454     5456       +2     
==========================================
+ Hits         2589     2591       +2     
  Misses       2604     2604              
  Partials      261      261
Impacted Files Coverage Δ
hack/schemas/main.go 87.79% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb51880...742aa9f. Read the comment docs.

@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@priyawadhwa priyawadhwa added the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 20, 2019
@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Feb 21, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 21, 2019
@dgageot dgageot added the docs-modifications runs the docs preview service on the given PR label Feb 21, 2019
@container-tools-bot

This comment has been minimized.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Feb 21, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This.is.so.cool.
thank you :)

@balopat
Copy link
Contributor

balopat commented Feb 21, 2019

Follow-up thoughts for next iterations (we don't have to do it in this PR, but we have to do it before the release)

  • we need to lift over all the comments from annotated-skaffold.yaml and then get rid of it, but I'm guessing that that's your plan. For example the 'test' section just says "describes how images are tested." - which is obviously not enough.
  • Also, we should turn off the "Edit page" button on the right hand side for this page and the CLI page as they are autogenerated

@dgageot dgageot merged commit 0f554f4 into GoogleContainerTools:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants