Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta6 #1674

Merged
merged 3 commits into from
Feb 25, 2019
Merged

v1beta6 #1674

merged 3 commits into from
Feb 25, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 19, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #1674 into master will increase coverage by 0.1%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1674     +/-   ##
=========================================
+ Coverage   46.54%   46.65%   +0.1%     
=========================================
  Files         123      125      +2     
  Lines        5618     5644     +26     
=========================================
+ Hits         2615     2633     +18     
- Misses       2734     2738      +4     
- Partials      269      273      +4
Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 65.85% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta5/config.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta4/upgrade.go 58.62% <100%> (ø) ⬆️
pkg/skaffold/schema/v1beta5/upgrade.go 63.63% <63.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218b0ec...3036f56. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 19, 2019

Codecov Report

Merging #1674 into master will increase coverage by 0.09%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1674      +/-   ##
=========================================
+ Coverage   47.41%   47.5%   +0.09%     
=========================================
  Files         122     124       +2     
  Lines        5448    5481      +33     
=========================================
+ Hits         2583    2604      +21     
- Misses       2604    2610       +6     
- Partials      261     267       +6
Impacted Files Coverage Δ
pkg/skaffold/schema/v1beta4/upgrade.go 58.62% <ø> (ø) ⬆️
pkg/skaffold/schema/versions.go 65.85% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta5/config.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta5/upgrade.go 58.62% <58.62%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acde29d...0e13cbd. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment!

@dgageot
Copy link
Contributor

dgageot commented Feb 20, 2019

LGTM but needs to be rebased

@balopat balopat merged commit ab113f2 into GoogleContainerTools:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants